Tag Archives: pull requests

Hacktoberfest 2018: write 5 pull requests for a free t-shirt

Reading Time: 6 minutes

Hello Mishamigos, in a week we will be the last day of October. The day where ghouls and demons will sprout and throw one more spell at us humble coding people. The day where until the last second you will look at your inbox petrified waiting for the next jump scare. As you guessed, in case you were oblivious to the post title, tomorrow is the first day of the last week of Hacktoberfest, 2018 edition.

Continue reading

Mister Ozymandie: A song of dice and dire

Reading Time: 2 minutes

Tick, tick, tick look at me it’s Mister Ozymandie,
Once more bringing, no, inflicting my opinion upon thee.
Whatever the effort, the time you put in your source,
My remarks, of your good day, will disrupt the course.

No matter how close you were to a merge
It is time for me to compare with yours my verge.
I am the biggest, the best, better than the rest
The victim you will be of my self-esteem quest.

Continue reading

Trying to provide helpful pull request reviews

Reading Time: 3 minutes

How I unblocked a frozen pull request

A few weeks ago, I saw a pull request to modify one of our web jobs which codebase is pretty old and had no tests. The pull request had no tests either. The thing is that we decided to make unit testing mandatory for any pull requests a couple of weeks before.

I started reviewing the code when I noticed someone else already posted a review. A pretty laconic “please add tests”. Not a bad nor a mean review but not a really helpful one. Proof of it is that it was posted about an hour before and the pull request was blocked. Indeed we do not untested logic to enter or remain in our software. Yes, it is aligned with our new policy about tests. That being said, the web job code was tightly coupled and pretty impossible to test as it was.

Continue reading